Skip to content

Adding simple helm CI #1635

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 26, 2025
Merged

Adding simple helm CI #1635

merged 1 commit into from
Sep 26, 2025

Conversation

kfswain
Copy link
Collaborator

@kfswain kfswain commented Sep 22, 2025

/kind test

Fixes: #1632

@k8s-ci-robot
Copy link
Contributor

@kfswain: The label(s) kind/test cannot be applied, because the repository doesn't have them.

In response to this:

/kind test

Fixes: #1632

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@netlify Netlify
Copy link

netlify bot commented Sep 22, 2025 •
edited
Loading

✅ Deploy Preview for gateway-api-inference-extension ready!

Name Link
🔨 Latest commit 9f6acec
🔍 Latest deploy log https://app.netlify.com/projects/gateway-api-inference-extension/deploys/68d6edb23df44b000895e86f
😎 Deploy Preview https://deploy-preview-1635--gateway-api-inference-extension.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 22, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kfswain

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 22, 2025
@kfswain
Copy link
Collaborator Author

kfswain commented Sep 22, 2025

CC: @nirrozenbaum @ahg-g @liu-cong

@kfswain kfswain force-pushed the helm-ci-addition branch 2 times, most recently from 4f2119f to 471cf44 Compare September 23, 2025 01:43
liu-cong
liu-cong reviewed Sep 23, 2025
View reviewed changes
@kfswain kfswain force-pushed the helm-ci-addition branch 2 times, most recently from 9a70727 to ecce92b Compare September 23, 2025 19:25
@liu-cong
Copy link
Contributor

Looks like a check failed, will lgtm once that's passing.

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 25, 2025
@nirrozenbaum
Copy link
Contributor

seems like an issue in CI.
I tried to fix, checking if the fix works:

/retest

@kfswain
Copy link
Collaborator Author

kfswain commented Sep 26, 2025

/hold

Erroneous file addition

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 26, 2025
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 26, 2025
@kfswain
Copy link
Collaborator Author

kfswain commented Sep 26, 2025

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 26, 2025
@liu-cong
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 26, 2025
@k8s-ci-robot k8s-ci-robot merged commit f806677 into kubernetes-sigs:main Sep 26, 2025
11 checks passed
@nirrozenbaum nirrozenbaum mentioned this pull request Sep 26, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@danehans danehans Awaiting requested review from danehans

1 more reviewer

@liu-cong liu-cong liu-cong left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@liu-cong liu-cong

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add helm dry-run to makefile & to the 'test' make command

4 participants

@kfswain @k8s-ci-robot @liu-cong @nirrozenbaum